[PATCH] D84220: [IPSCCP] Fix a bug that the "returned" attribute is not cleared when function is optimized to return undef

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 12:36:10 PDT 2020


lebedev.ri added a comment.

In D84220#2179754 <https://reviews.llvm.org/D84220#2179754>, @davide wrote:

> Florian, can you take a look?

On Tue, Jul 28, 2020 at 10:35 PM Florian Hahn via llvm-commits <llvm-commits at lists.llvm.org> wrote:

>> On Jul 28, 2020, at 20:32, Congzhe Cao via Phabricator <reviews at reviews.llvm.org> wrote:
>>
>> congzhe added a comment.
>>
>> Could you review this patch please? Thank you! @nikic @davide @efriedma
>
> As I mentioned already, I have some comments in phabricator, but cannot submit them because "You do not have permission to edit this object.”
>
> FWIW it is not common to lock down reviews to require Admin permissions.
>
> _______________________________________________
>
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84220/new/

https://reviews.llvm.org/D84220



More information about the llvm-commits mailing list