[PATCH] D84772: [NewPM][PassInstrument] Add a new kind of before-pass callback that only get called if the pass is not skipped

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

What about unit tests?



================
Comment at: llvm/include/llvm/IR/PassInstrumentation.h:71
+  // BeforeNonSkippedPassFunc is called when we know for sure that the pass
+  // would be run. BeforePassFunc could not make such assumption.
   // TODO: currently AfterPassInvalidated does not accept IRUnit, since passing
----------------
Rather than this sentence, I think there should be a comment that we call all BeforePassFuncs to determine if the pass should run or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84772/new/

https://reviews.llvm.org/D84772