[PATCH] D84775: [X86] Remove disabled miscompiling X86CondBrFolding pass

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri created this revision.
lebedev.ri added a reviewer: craig.topper.
lebedev.ri added a project: LLVM.
Herald added subscribers: hiraditya, mgorny.
lebedev.ri requested review of this revision.

As briefly discussed in IRC with @craig.topper,
the pass is disabled basically since it's original introduction (nov 2018)
due to  known correctness issues (miscompilations), 
and there hasn't been much work done to fix that.

While i won't promise that i will "fix" the pass,
i have looked at it previously, and i'm sure i won't try to fix it
if that requires actually fixing this existing code.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84775

Files:
  llvm/lib/Target/X86/CMakeLists.txt
  llvm/lib/Target/X86/X86.h
  llvm/lib/Target/X86/X86.td
  llvm/lib/Target/X86/X86CondBrFolding.cpp
  llvm/lib/Target/X86/X86Subtarget.h
  llvm/lib/Target/X86/X86TargetMachine.cpp
  llvm/lib/Target/X86/X86TargetTransformInfo.h
  llvm/test/CodeGen/X86/condbr_if.ll
  llvm/test/CodeGen/X86/condbr_switch.ll
  llvm/test/CodeGen/X86/test_x86condbr_globaladdr.mir
  llvm/utils/gn/secondary/llvm/lib/Target/X86/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84775.281287.patch
Type: text/x-patch
Size: 36015 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200728/6f49c51b/attachment.bin>