[PATCH] D84233: [lit] Escape ANSI control character in xunit output

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 10:17:26 PDT 2020


yln added a comment.

In D84233#2176397 <https://reviews.llvm.org/D84233#2176397>, @jdenny wrote

> I still wonder whether it would be more helpful to drop control characters rather than irreversibly escape them.  Dropping them makes the output more readable.  Reversibly escaping them makes it possible to feed the text to a tool that can render the control codes.  Irreversibly escaping them doesn't achieve either of those advantages, and I'm not sure if it serves a real use case.  Any comments on this question?

I agree with Joel here and would like to see this done as part of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84233/new/

https://reviews.llvm.org/D84233



More information about the llvm-commits mailing list