[PATCH] D84765: [NFC][AIX][XCOFF] remove setting storageclass in function .getXCOFFSection and construct function of class MCSectionXCOFF

Digger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 09:35:41 PDT 2020


DiggerLin created this revision.
DiggerLin added reviewers: jasonliu, hubert.reinterpretcast, Xiangling_L, daltenty.
Herald added subscribers: llvm-commits, kbarton, hiraditya, nemanjai.
Herald added a project: LLVM.
DiggerLin requested review of this revision.
Herald added a subscriber: wuzish.

there are

XCOFF::StorageMappingClass MappingClass;
XCOFF::SymbolType Type;
XCOFF::StorageClass StorageClass;
in the MCSectionXCOFF class,
these attribute only used in the XCOFFObjectWriter, (asm path do not need the StorageClass)

we need get the value of StorageClass, Type,MappingClass before we invoke the getXCOFFSection every time.

actually for the StorageClass, we can set the value of StorageClass when set the
MCXCOFFStreamer::emitSymbolAttribute(). (for common link we can set at MCXCOFFStreamer::emitCommonSymbol).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84765

Files:
  llvm/include/llvm/MC/MCContext.h
  llvm/include/llvm/MC/MCSectionXCOFF.h
  llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  llvm/lib/MC/MCContext.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/MC/MCXCOFFStreamer.cpp
  llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84765.281256.patch
Type: text/x-patch
Size: 14330 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200728/93904799/attachment.bin>


More information about the llvm-commits mailing list