[PATCH] D83088: Introduce CfgTraits abstraction

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 08:02:22 PDT 2020


arsenm added inline comments.


================
Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:50
+
+  // Clang's CFG contains nullpointers for unreachable succesors, e.g. when an
+  // if statement's condition is always false, it's 'then' branch is represented
----------------
Missing space nullpointers, missing s succesors


================
Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:51
+  // Clang's CFG contains nullpointers for unreachable succesors, e.g. when an
+  // if statement's condition is always false, it's 'then' branch is represented
+  // with a nullptr. Account for this in the predecessors / successors
----------------
s/it's/its/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83088/new/

https://reviews.llvm.org/D83088



More information about the llvm-commits mailing list