[PATCH] D84462: Rename options for basic block sections to be consistent

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/basic-block-sections.ll:2
+; REQUIRES: x86
+; LTO
+; RUN: llvm-as %s -o %t.o
----------------
Delete this line.


================
Comment at: lld/test/ELF/lto/basic-block-sections.ll:4
+; RUN: llvm-as %s -o %t.o
+; RUN: ld.lld %t.o -o %t.out --lto-basic-block-sections=all --lto-unique-basic-block-section-names --lto-O0 -save-temps
+; RUN: llvm-readobj -s %t.out.lto.o | FileCheck --check-prefix=SECNAMES %s
----------------
-save-temps -> --save-temps

For LLD specific long options, we prefer double-dash forms.

You can just use `-o %t` 

Do you need another RUN line without --lto-unique-basic-block-section-names ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84462/new/

https://reviews.llvm.org/D84462