[PATCH] D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis

rithik sharma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 07:24:29 PDT 2020


RithikSharma marked an inline comment as done.
RithikSharma added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:252
+      return false;
+    auto DestMemLoc = MemoryLocation::get(Inst);
+
----------------
bmahjour wrote:
> MemoryLocation::get returns "none" if Inst is a call. Please add special handling for calls and make sure your tests cover it.
Test case pending.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84589/new/

https://reviews.llvm.org/D84589



More information about the llvm-commits mailing list