[PATCH] D84733: [Attributor] Check nonnull attribute violation in AAUndefinedBehavior

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:2024
                               /* CheckBBLivenessOnly */ true);
+    A.checkForAllCallLikeInstructions(InspectCallSiteForUB, *this);
     if (NoUBPrevSize != AssumedNoUBInsts.size() ||
----------------
Please add a third argument specifying the instructions to check, i.e. `{Instruction::CallSite}`. Also, a fourth argument `true` as a value, like the other too above.


================
Comment at: llvm/test/Transforms/Attributor/value-simplify.ll:409
 ; IS__TUNIT____-SAME: (%struct.X** nocapture nofree writeonly [[B:%.*]])
-; IS__TUNIT____-NEXT:    call void @test_sret(%struct.X* noalias nocapture nofree writeonly align 536870912 null, %struct.X** nocapture nofree writeonly align 8 [[B]])
-; IS__TUNIT____-NEXT:    ret void
+; IS__TUNIT____-NEXT:    unreachable
 ;
----------------
Hmm.. We probably need to fix the undefined behavior in this testcase.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84733/new/

https://reviews.llvm.org/D84733