[PATCH] D84038: On Windows build, making the /bigobj flag global , instead of passing it per file.
Zahira Ammarguellat via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 28 05:56:14 PDT 2020
zahiraam added inline comments.
================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:472
+ # Making this flag global instead of per file.
+ append("/bigobj" CMAKE_CXX_FLAGS)
endif( MSVC )
----------------
Meinersbur wrote:
> Consider `add_compile_options` instead? `CMAKE_CXX_FLAGS` is meant to be defined by the user. However, since the rest of the file also appends to `CMAKE_CXX_FLAGS`, might also leave it consistent with the others.
Opted to be consistent and use the append instead. OK?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84038/new/
https://reviews.llvm.org/D84038
More information about the llvm-commits
mailing list