[PATCH] D84640: [llvm-readelf] Fix emitting incorrect number of spaces in '--hex-dump'.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Some comment fixes. Please create a new commit for these and submit.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/hex-dump.test:52
+
+## Test that llvm-readelf emits a correct amount of spaces between the hex data
+## and its ascii representation.
----------------
Nits:
a correct -> the correct
amount -> number


================
Comment at: llvm/test/tools/llvm-readobj/ELF/hex-dump.test:55
+
+## a) When the hex data doesn't fill the column whose index isn't 4.
+# RUN: yaml2obj --docnum=2 -DSIZE=18 %s -o %t2.out1
----------------
This comment is clunky. Try:

"the column whose index isn't 4" -> "a column other than the last one"


================
Comment at: llvm/test/tools/llvm-readobj/ELF/hex-dump.test:64
+
+## b) When the hex data doesn't fill the column whose index is 4.
+# RUN: yaml2obj --docnum=2 -DSIZE=30 %s -o %t2.out2
----------------
Similarly:

"doesn't fill the last column"


================
Comment at: llvm/test/tools/llvm-readobj/ELF/hex-dump.test:73
+
+## c) When the hex data fills the column.
+# RUN: yaml2obj --docnum=2 -DSIZE=28 %s -o %t2.out3
----------------
fills the -> fills a


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84640/new/

https://reviews.llvm.org/D84640