[PATCH] D84700: [ThinLTO] [test] cache.ll: Prevent Spotlight indexing of the output dir

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 28 04:21:43 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.

No issues from my point of view, aside from the suggested comment change.



================
Comment at: llvm/test/ThinLTO/X86/cache.ll:4
 
+; The .noindex suffix for output dir is to prevent Spotlight from indexing it.
+
----------------
Since this test isn't macOS specific, perhaps it's best to change this comment to:

"The .noindex suffix for output dir is to prevent Spotlight on MacOS from indexing it."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84700/new/

https://reviews.llvm.org/D84700



More information about the llvm-commits mailing list