[PATCH] D84399: [SCEVExpander] Avoid re-sing existing casts if it means updating users.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 3 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopDistribute/bounds-expansion-bug.ll:3
 
+; XFAIL: *
+
----------------
mkazantsev wrote:
> Is it XFAIL with a crash? If it's not, I'd like to see checks update and FIXME comment instead.
The FIXME is not longer needed :)


================
Comment at: llvm/test/Transforms/LoopDistribute/bounds-expansion-bug.ll:8
+; should only be a small optimization and can be re-introduced once we can
+; properly clean up expansion results, if they are unused.
+
----------------
lebedev.ri wrote:
> efriedma wrote:
> > Does the pass semantically depend on reusing casts, or does failing to reuse casts just make the generated code uglier?
> If this is a single test that actually ensures that casts are reused,
> i'm not sure it's a very cornerstone feature of the pass.
I updated the code to allow for better re-using existing casts even in the updated version. There is no regression in this test any longer, other than the fact that we do not generate the 'invalidate' bit casts any longer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84399/new/

https://reviews.llvm.org/D84399