[PATCH] D84738: [yaml2obj] - Add a way to override sh_type section field.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/override-shtype.yaml:34
+    Flags:  [ SHF_ALLOC ]
+    ShType: [[TYPE=SHT_GNU_verneed]]
+    Info:   0
----------------
grimar wrote:
> jhenderson wrote:
> > As you don't use the YAML for a non-overridden type, you can omit the `=SHT_GNU_verneed`, right?
> It is used for a non-overridden type:
> 
> ```
> # RUN: yaml2obj %s -o %t1
> # RUN: llvm-readobj --sections --section-data %t1 | FileCheck %s --check-prefixes=COMMON,ORIGINAL
> ```
> 
> If I omitted the `=SHT_GNU_verneed` here, I would need to use `yaml2obj -DTYPE=SHT_GNU_verneed`.
Oh, I missed the first run somehow, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84738/new/

https://reviews.llvm.org/D84738