[PATCH] D84717: [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in()
Stefanos Baziotis via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 28 03:36:58 PDT 2020
baziotis added a comment.
In D84717#2178123 <https://reviews.llvm.org/D84717#2178123>, @RKSimon wrote:
> Please can you add unit test coverage at llvm/unittest/ADT/BitVectorTest.cpp
Why? I mean, this is NFC, there's no new functionality added. What was tested previously, is tested still (more specifically, there are already tests for these two functions). Do I miss something?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84717/new/
https://reviews.llvm.org/D84717
More information about the llvm-commits
mailing list