[PATCH] D84634: [NFC] [MIR] Document the reg state flags
Djordje Todorovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 27 23:27:41 PDT 2020
djtodoro added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/MachineInstrBuilder.h:45
+ Define = 0x2, ///< Register definition.
+ Implicit = 0x4, ///< Not emitted register (e.g. carry, or
+ ///< temporary result).
----------------
aprantl wrote:
> This is personal preference, but IMO, once comments span more than one line the
> ```
> enum {
> /// Register definition.
> Define = 0x2,
> ///Not emitted register (e.g. carry, or
> ///temporary)
> Implicit = 0x4,
>
> ```
>
> format is less confusing to read.
It makes sense :) Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84634/new/
https://reviews.llvm.org/D84634
More information about the llvm-commits
mailing list