[PATCH] D68041: [PGO] Don't group COMDAT variables for compiler generated profile variables in ELF

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 27 21:52:25 PDT 2020


MaskRay added a comment.

I think a potentially better approach is to reuse an existing symbol name as the comdat name (D84723 <https://reviews.llvm.org/D84723>). The state before this patch was inferior because `__profv_` created a symbol which might waste .strtab space. By reusing an existing symbol (I picked `__profd_`), we don't waste space.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68041/new/

https://reviews.llvm.org/D68041



More information about the llvm-commits mailing list