[PATCH] D84038: Passing the flag bigobj globally when building debug compiler on Windows

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:471
   endif()
+  # Making this flag global instead of per file.
+  append("/bigobj" CMAKE_CXX_FLAGS)
----------------
This comment belongs into the commit description; readers of this file will not see what the previous state was. Maybe explain here why /bigobj is needed, as by the lines removed:
```
# By default MSVC has a 2^16 limit on the number of sections in an object file,
```


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:472
+  # Making this flag global instead of per file.
+  append("/bigobj" CMAKE_CXX_FLAGS)
 endif( MSVC )
----------------
Consider `add_compile_options` instead? `CMAKE_CXX_FLAGS` is meant to be defined by the user. However, since the rest of the file also appends to `CMAKE_CXX_FLAGS`, might also leave it consistent with the others.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84038/new/

https://reviews.llvm.org/D84038