[PATCH] D84689: [OpenMPOpt] Most SCC's are uninteresting, don't waste time on them (up to 16x faster)
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 27 13:33:16 PDT 2020
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for discovering and fixing this :)
================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:1415
SmallVector<Function *, 16> SCC;
- for (CallGraphNode *CGN : CGSCC)
- if (Function *Fn = CGN->getFunction())
- if (!Fn->isDeclaration())
- SCC.push_back(Fn);
+ // If there are kernels in the module, we have to run on all SCC's
+ bool SCCIsInteresting = !OMPInModule.getKernels().empty();
----------------
1) For now ;)
2) missing `.`, also above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84689/new/
https://reviews.llvm.org/D84689
More information about the llvm-commits
mailing list