[PATCH] D84471: [X86] Fix for ballooning compile times due to Load Value Injection (LVI) mitigations
Scott Constable via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 27 13:21:57 PDT 2020
sconstab marked 2 inline comments as done.
sconstab added inline comments.
================
Comment at: llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp:667-669
+ // If `MF` does not have any fences, then no gadgets would have been
+ // mitigated at this point.
+ if (Graph->NumFences > 0) {
----------------
mattdr wrote:
> Can we add this as an early-exit case in `trimMitigatedEdges` instead?
>
That would negatively impact the `hardenLoadsWithPlugin()` flow that may need to `trimMitigatedEdges()` even if `Graph->NumFences == 0`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84471/new/
https://reviews.llvm.org/D84471
More information about the llvm-commits
mailing list