[PATCH] D84629: [LazyValueInfo] Let getEdgeValueLocal look into freeze instructions

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Analysis/LazyValueInfo.cpp:1316
+          (isa<FreezeInst>(Val) &&
+           Condition == cast<FreezeInst>(Val)->getOperand(0)))
         return ValueLatticeElement::get(ConstantInt::get(
----------------
nikic wrote:
> Wouldn't we expect such a freeze to get dropped by InstSimplify/InstCombine anyway?
You mean, we should rewrite uses of a freeze in blocks where we know the operand of the freeze can't be undef/poison?  I guess that's something we should do.  I don't think instsimplify has the context necessary to do that sort of rewrite.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84629/new/

https://reviews.llvm.org/D84629