[PATCH] D83875: [XCOFF][AIX] Enable -ffunction-sections
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 27 12:10:39 PDT 2020
jasonliu marked an inline comment as done.
jasonliu added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5348
const XCOFF::StorageClass &SC) {
MCSymbolXCOFF *S = getFunctionEntryPointSymbol(FuncName);
----------------
Xiangling_L wrote:
> I am wondering why we don't just use `Subtarget.getTargetMachine().getObjFileLowering().getFunctionEntryPointSymbol` instead? And all the logic below about how we get the `MCSymbolXCOFF` should be simplified by doing this?
Good point. I created NFC patch to address this issue: D84693.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83875/new/
https://reviews.llvm.org/D83875
More information about the llvm-commits
mailing list