[PATCH] D77251: [llvm][CodeGen] Addressing modes for SVE ldN.

Mon Jul 27 10:11:17 PDT 2020

fpetrogalli added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:248
   void SelectPostLoadLane(SDNode *N, unsigned NumVecs, unsigned Opc);
-  void SelectPredicatedLoad(SDNode *N, unsigned NumVecs, const unsigned Opc);
+  template <unsigned Scale>
+  void SelectPredicatedLoad(SDNode *N, unsigned NumVecs, const unsigned Opc_rr,
----------------
sdesmalen wrote:
> Sorry, one more thing, can you make `Scale` a normal argument rather than a template argument?
> I see that D77435 also uses a template argument for the stores, rather than a regular argument. I guess you can fix that one separately in an NFC patch.
NFC committed as https://github.com/llvm/llvm-project/commit/dbeb184b7f54db2d3ef20ac153b1c77f81cf0b99

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77251/new/

https://reviews.llvm.org/D77251