[PATCH] D79162: [Analysis] TTI: Add CastContextHint for getCastInstrCost

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 27 09:31:22 PDT 2020


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

I think there's consensus this patch is a reasonable fix. So, this LGTM, but please wait a day in case there are more comments.



================
Comment at: llvm/lib/Analysis/TargetTransformInfo.cpp:705
 
+static TTI::CastContextHint computeExtCastContextHint(const Instruction *I) {
+  const Instruction *CtxInst = dyn_cast<Instruction>(I->getOperand(0));
----------------
Can this and `computeTruncCastContextHint` be merged into 1 function? Essentially only the cases in the switch are different, which can be merged.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79162/new/

https://reviews.llvm.org/D79162





More information about the llvm-commits mailing list