[PATCH] D84569: [ELF] --reproduce should include lto sample profile

Christy Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 27 08:59:32 PDT 2020


christylee marked an inline comment as done.
christylee added inline comments.


================
Comment at: lld/ELF/Driver.cpp:506
 
   readConfigs(args);
 
----------------
MaskRay wrote:
> Just move this line above so that we can use `config->ltoSampleProfile`
If we move `config->ltoSampleProfile` up to before `getReproduceOptions(args)`, then symbol ordering file, dynamic list, and version script will be consumed before the tar object is created, so they won't be included in the `repro.tar`.  Would it be better if I move this to where we parse LTO options?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84569/new/

https://reviews.llvm.org/D84569





More information about the llvm-commits mailing list