[PATCH] D83875: [XCOFF][AIX] Enable -ffunction-sections

[Xiangling Liao via Phabricator via llvm-commits]

Xiangling_L added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2088
     const Function &F, const TargetMachine &TM) const {
   assert (!TM.getFunctionSections() && "Unique sections not supported on XCOFF"
           " yet.");
----------------
Should we also handle this in this patch?


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2172
+  // function entry point label any more. We will use function entry
+  // point csect instead. For function delcarations, it's Okay to continue
+  // using label semantic because undefined symbols gets treated as csect with
----------------
s/Okay/okay?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83875/new/

https://reviews.llvm.org/D83875