[PATCH] D84614: [Attributor][WIP] Cost interface for function internalization

[Luofan Chen via Phabricator via llvm-commits]

bbn marked an inline comment as done.
bbn added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:145
+
+} // namespace InternalizeConstants
+
----------------
jdoerfert wrote:
> Make the names more descriptive and add plenty doxygen documentation for all of them. Maybe put them all in a struct so the user could modify the values by changing the struct members.
Sure, I will add docs once I figure out the when to do such cost analysis and what 
can increase the cost of internalization (for now I can only think of the number of
instructions) and what can be the "bonus".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84614/new/

https://reviews.llvm.org/D84614