[PATCH] D84581: [VE] Change calling convention to follow ABI

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 27 00:42:35 PDT 2020


simoll added a comment.

Nit. LGTM otherwise.



================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:214
+    // a float argument is converted to i64 first, and stored as 8 bytes
+    // data, which is required by ABI, so no need any adjustment.
+    //    0      4
----------------
suggestion: "no need //for// adjustment"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84581/new/

https://reviews.llvm.org/D84581





More information about the llvm-commits mailing list