[PATCH] D79219: [CMake] Simplify CMake handling for zlib

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 25 18:13:07 PDT 2020


mehdi_amini added inline comments.


================
Comment at: mlir/examples/standalone/CMakeLists.txt:35
+endif()
+
 include(TableGen)
----------------
mehdi_amini wrote:
> I am a bit unsure that it is desirable that it is desirable to need this change?
> This requires every single user of LLVM to do this. Is there a way this can be done in the call to `find_package(LLVM)` instead?
(Doc for the usual way to integrate LLVM: https://llvm.org/docs/CMake.html#embedding-llvm-in-your-project )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79219/new/

https://reviews.llvm.org/D79219





More information about the llvm-commits mailing list