[PATCH] D79219: [CMake] Simplify CMake handling for zlib

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 16:29:05 PDT 2020


Thanks, that addressed the issue.

> On Jul 24, 2020, at 1:41 PM, Petr Hosek <phosek at google.com> wrote:
> 
> Thanks for the heads up, this should be addressed by c86f56e32e724c6018e579bb2bc11e667c96fc96, let me know if there are other issues.
> 
> On Fri, Jul 24, 2020 at 12:33 PM Vedant Kumar via Phabricator <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
> vsk added a comment.
> 
> @phosek I suspect this is causing a cmake error on the lldb standalone bot, would you mind taking a look?
> 
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake-standalone/1858/ <http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake-standalone/1858/>
> 
>   CMake Error at /Users/buildslave/jenkins/workspace/lldb-cmake-standalone/clang-build/lib/cmake/llvm/AddLLVM.cmake:823 (add_executable):
>     Target "lit-cpuid" links to target "ZLIB::ZLIB" but the target was not
>     found.  Perhaps a find_package() call is missing for an IMPORTED target, or
>     an ALIAS target is missing?
>   Call Stack (most recent call first):
>     cmake/modules/AddLLDB.cmake:165 (add_llvm_executable)
>     utils/lit-cpuid/CMakeLists.txt:1 (add_lldb_executable)
> 
> 
> Repository:
>   rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D79219/new/ <https://reviews.llvm.org/D79219/new/>
> 
> https://reviews.llvm.org/D79219 <https://reviews.llvm.org/D79219>
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200724/b0ec7aeb/attachment-0001.html>


More information about the llvm-commits mailing list