[PATCH] D84386: [DWARFYAML] Add support for emitting custom operands for range list entry.

Sun Jul 26 22:55:17 PDT 2020

Higuoxing added a comment.

In D84386#2168871 <https://reviews.llvm.org/D84386#2168871>, @jhenderson wrote:

> In D84386#2168864 <https://reviews.llvm.org/D84386#2168864>, @labath wrote:
>
> > In D84386#2168813 <https://reviews.llvm.org/D84386#2168813>, @jhenderson wrote:
> >
> > > In general terms, I think this is a good solution. Let's see what @grimar and @labath think.
> >
> >
> > Pretty much what I said already. This might be a nice way to test parsing of unknown/invalid DW_LLE constants, but there's only so many of those kinds of tests that we need, so it seems unnecessary.
> >
> > Furthermore, once we're down in the invalid input land, it becomes very important to know how the bytes are laid out exactly in order to understand what the parser will do/has done. This becomes a (small) obstacle in that because I have to reason about the actual byte sequence that will be produced by this yaml -- I would prefer if I just had the bytes directly.
> >
> > But if you do want to have this, I'm not going to stop you...
>
>
> @Higuoxing, could you put up a patch that uses the hex approach @labath is suggesting instead of this approach, please? We can then better compare the complexity etc of the two approaches.

I've implemented one in D84618 <https://reviews.llvm.org/D84618> :-) Any thoughts?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84386/new/

https://reviews.llvm.org/D84386