[PATCH] D83592: [Coverage] Add comment to skipped regions

[Zequan Wu via Phabricator via llvm-commits]

zequanwu added a comment.

In D83592#2174600 <https://reviews.llvm.org/D83592#2174600>, @vsk wrote:

> In D83592#2170912 <https://reviews.llvm.org/D83592#2170912>, @zequanwu wrote:
>
> > I don't why when using the cmake option `-DLLVM_BUILD_INSTRUMENTED_COVERAGE=On` to test coverage for clang itself, it does tracking comments.
> >  Also, with that option on, `llvm-cov` crashes at assertion:`llvm/lib/ProfileData/Coverage/CoverageMappingReader.cpp:578: virtual Expected<const char *> (anonymous namespace)::VersionedCovMapFuncRecordReader<llvm::coverage::Version4, unsigned long, llvm::support::little>::readCoverageHeader(const char *, const char *, BinaryCoverageReader::DecompressedData &) [Version = llvm::coverage::Version4, IntPtrT = unsigned long, Endian = llvm::support::little]: Assertion `(CovMapVersion)CovHeader->getVersion<Endian>() == Version' failed.`
>
>
> Just to double-check: are you using llvm-{cov,profdata} binaries from the stage1 llvm build to produce reports for stage2 (coverage-instrumented) binaries?


I didn't config correctly before. I just tried. It works correctly now, not tracking comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83592/new/

https://reviews.llvm.org/D83592