[PATCH] D84598: [JumpThreading] Add a basic support for freeze instruction

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 26 06:00:10 PDT 2020


nikic added a comment.

Just as a side note, you may want to add freeze support to foldOpIntoPhi() in InstCombine, which I believe will also catch the two cases being tested here.



================
Comment at: llvm/test/Transforms/JumpThreading/freeze.ll:30
+Merge:
+  %A = phi i1 [true, %T1], [false, %F1]
+  %B = phi i32 [%v1, %T1], [%v2, %F1]
----------------
We should also have a negative test, say for undef as phi operand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84598/new/

https://reviews.llvm.org/D84598





More information about the llvm-commits mailing list