[PATCH] D84479: [X86] Detect if EFLAGs is live across XBEGIN pseudo instruction. Add it as livein to the basic blocks created when expanding the pseudo

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 25 11:38:05 PDT 2020


craig.topper added a comment.

In D84479#2174059 <https://reviews.llvm.org/D84479#2174059>, @ivanbaev wrote:

> Thank you for checking on mainMBB and fallBB. Which direction: forward or backward  - do you prefer for isEFLAGSLiveAfter()?


I think I'd prefer to keep the forward direction.  The code is shared with cmov handling which is also fixing incorrect kill flags on the cmov pseudo instruction.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84479/new/

https://reviews.llvm.org/D84479





More information about the llvm-commits mailing list