[PATCH] D84328: [ScheduleDAGRRList] Limit number of candidates to explore.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/stress-scheduledagrrlist.ll:12
+  ret void
+}
----------------
fhahn wrote:
> RKSimon wrote:
> > fhahn wrote:
> > > RKSimon wrote:
> > > > @fhahn Should this be in x86 or generic codegen tests? I wouldn't have noticed it but its causing a notable increase in runtime for the x86 codegen tests.....
> > > It's intentional for X86 to check that we don't have excessive compile-times (the patch improves compile-time by ~ 100x). On my system, it takes ~1-2 seconds, but if that's too long we can reduce the width of the type further.
> > Hmm - please can you check an EXPENSIVE_CHECKS build? I'm seeing > 6min for this.
> oh right, I think there is some very expensive checks somewhere in SelectionDAG and there will be a very large number of nodes.... Is there a way to disable tests for builds with expensive checks? Otherwise we probably should remove the test.
I can't think of a way for lit to check for non EXPENSIVE_CHECKS builds - and I'd be worried that such an approach would be abused tbh.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84328/new/

https://reviews.llvm.org/D84328