[PATCH] D84264: [SCCP] Directly remove non-feasible edges

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.

In D84264#2173974 <https://reviews.llvm.org/D84264#2173974>, @nikic wrote:

> Apply DTU updates only //after// changing the CFG and add previously crashing test. This is the first point in the CAUTION list at https://github.com/llvm/llvm-project/blob/3c1476d26c769cd97a631a129b30c62232ac96b6/llvm/include/llvm/Analysis/DomTreeUpdater.h#L135-L139.


That sounds right, thanks! LGTM



================
Comment at: llvm/test/Transforms/SCCP/domtree-update.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -S -passes=ipsccp < %s | FileCheck %s
+
----------------
perhaps also add `verify<domtree>` 

Also, even though we don't actively preserve the DT with the legacy pass manager, we might as well run the test with the legacy pass manager as well. Or add a note why we only check the NewPM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84264/new/

https://reviews.llvm.org/D84264