[PATCH] D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions)

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 22:42:46 PDT 2020


MaskRay added a comment.

> Not matching the (real) variadic declaration makes the interceptor take garbage inputs on AArch64.

Is this Darwin specific or does it apply to aarch64-linux as well?



================
Comment at: compiler-rt/test/tsan/Darwin/variadic-open.cpp:1
+// RUN: %clangxx_tsan -O1 %s -o %t && %run %t %t.tmp 2>&1 | FileCheck %s
+#include <stdio.h>
----------------
Is this Darwin specific or does it apply to aarch64-linux as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84570/new/

https://reviews.llvm.org/D84570





More information about the llvm-commits mailing list