[PATCH] D82603: AMDGPU: Implement waterfall loop for MIMG instructions with 256-bit SRsrc

[Changpeng Fang via Phabricator via llvm-commits]

cfang added a comment.

In D82603#2119746 <https://reviews.llvm.org/D82603#2119746>, @nhaehnle wrote:

> Could you make this generic over the VGPR register class instead? That code duplication is rather annoying.


I agree it does not look nice with the duplication. However, the existing implementation is easy to follow,
and I could not figure out a way that can easily generalize over vgpr class without make the code messy.

We will continue to work on to come out with a generalized solution. But in the mean time, we need 
the fix for a correctness issue which has been bothering us for a long time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82603/new/

https://reviews.llvm.org/D82603