[PATCH] D81929: [Attributor] Introduce CallBaseContext to the IRPosition

Fri Jul 24 16:37:20 PDT 2020

kuter marked an inline comment as done.
kuter added a comment.

In D81929#2172319 <https://reviews.llvm.org/D81929#2172319>, @jdoerfert wrote:

> LGTM with nits.

I made a mistake while creating this revision. 
This is incomplete. instead of amending the `[Attributor] Introduce CallBaseContext to the IRPosition` I created a new commit and when I did `arc diff` It updated to the state it is. 
I will update this to include all of the patch.

sorry for the mess.

================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:937
+#endif
+    IRP =
+        shouldPropagateCallBaseContext(IRP) ? IRP : IRP.stripCallBaseContext();
----------------
jdoerfert wrote:
> jdoerfert wrote:
> > Nit: newline
> > 
> > Now we are in a hybrid solution, should we do `if (should...) IRP = ...` ?
> my bad, `if (!should..`), right?
Yes thank you, I should have ran the tests in D83744 before updating the revision.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81929/new/

https://reviews.llvm.org/D81929