[PATCH] D84552: [AArch64][GlobalISel] Add legalization & selection support for G_INTRINSIC_LRINT

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/legalize-lrint.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -verify-machineinstrs -mtriple aarch64-unknown-unknown -run-pass=legalizer -global-isel %s -o - | FileCheck %s
+--- |
----------------
Don't need -global-isel with -run-pass


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/legalize-lrint.mir:16
+  declare i64 @llvm.lrint.i64.f32(float) #1
+  declare i64 @llvm.lrint.i64.f64(double) #1
+
----------------
Don't need the IR section 


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir:132
 # DEBUG-NEXT: .. imm index coverage check SKIPPED: user-defined predicate detected
+# DEBUG-NEXT: G_INTRINSIC_LRINT (opcode {{[0-9]+}}): 2 type indices, 0 imm indices
+# DEBUG-NEXT: .. opcode {{[0-9]+}} is aliased to {{[0-9]+}}
----------------
Probably needed this to exist in the patch defining the opcodes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84552/new/

https://reviews.llvm.org/D84552