[PATCH] D84504: [flang]Verify C7107, C7108, C7109 from - Clause 7 constraint checks for f18.

Fri Jul 24 12:47:07 PDT 2020

PeteSteinfeld added inline comments.

================
Comment at: flang/test/Semantics/boz-literal-constants.f90:49
+
+  !ERROR: Typeless (BOZ) not allowed for 'i=' argument
+  dbl = DSHIFTL(B"0101",B"0101",2)
----------------
tskeith wrote:
> PeteSteinfeld wrote:
> > sameeranjoshi wrote:
> > > Is error below a more proper one?
> > > ```
> > > Typeless (BOZ) not allowed for both 'i=' & 'j=' arguments.
> > > ```
> > > 16.9.65(3)
> > > > J shall be of type integer or a boz-literal-constant. If both I and J are of type integer, they shall have the same kind type parameter. I and J shall not both be boz-literal-constants
> > > 
> > > restricts variables I and J when both are `boz-literal-constants`, whereas the current error with flang trunk assumes 'i' to be wrong, and which might not give proper information to the user.
> > > 
> > I would say:
> > ```
> > Typeless (BOZ) not allowed for either 'i=' & 'j=' arguments.
> > ```
> I think @sameeranjoshi's version of this message is right. They can't both be BOZ literals but either one can be.
Good catch, Tim.  I just re-read the standard, and you're correct.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84504/new/

https://reviews.llvm.org/D84504