[PATCH] D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct

[Tim Keith via Phabricator via llvm-commits]

tskeith added inline comments.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:6483
   inExecutionPart_ = false;
-  ResolveOmpParts(x);
+  if (context().IsEnabled(Fortran::common::LanguageFeature::OpenACC))
+    ResolveAccParts(x);
----------------
You don't need `Fortran::`. Also, please include braces around the body of the `if` statements.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:6773
+
+  auto &outer{std::get<std::optional<parser::DoConstruct>>(x.t)};
+  for (const parser::DoConstruct *loop{&*outer}; loop && level > 0; --level) {
----------------
This is a good suggestion from clang-tidy. Use `const auto` rather than just `auto` when you can.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83998/new/

https://reviews.llvm.org/D83998