[PATCH] D84504: [flang]Verify C7107, C7108, C7109 from - Clause 7 constraint checks for f18.

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 11:49:49 PDT 2020


PeteSteinfeld requested changes to this revision.
PeteSteinfeld added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/lib/Evaluate/intrinsics.cpp:1134
           messages.Say(
-              "Typeless (BOZ) not allowed for '%s=' argument"_err_en_US,
-              d.keyword);
+              "Typeless (BOZ) not allowed for either '%s=' & '%s=' arguments"_err_en_US, // C7109
+              d.keyword, nextParam.keyword);
----------------
Sorry for not noticing this earlier, but the message should say:
```
Typeless (BOZ) not allowed for either '%s=' or '%s=' arguments
```


================
Comment at: flang/test/Semantics/boz-literal-constants.f90:49
+
+  !ERROR: Typeless (BOZ) not allowed for either 'i=' & 'j=' arguments
+  dbl = DSHIFTL(B"0101",B"0101",2)
----------------
The message also needs to be corrected here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84504/new/

https://reviews.llvm.org/D84504





More information about the llvm-commits mailing list