[PATCH] D84054: [lld][ELF] Add LOG2CEIL builtin ldscript function

Isaac Richter via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 11:37:50 PDT 2020


irichter added a comment.

In D84054#2170591 <https://reviews.llvm.org/D84054#2170591>, @MaskRay wrote:

> Use `llvm::Log2_64_Ceil` (llvm/Support/mathExtras.h)


Is it preferred coding style to include the namespace in a function call, when the file already has the relevant using namespace statement? Specifically, should I be using an unqualified `return Log2_64_Ceil(...);`, or a qualified `return llvm::Log2_64_Ceil(...);` call?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84054/new/

https://reviews.llvm.org/D84054





More information about the llvm-commits mailing list