[PATCH] D83669: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and the callee is not DSO local

[Victor Huang via Phabricator via llvm-commits]

NeHuang added inline comments.


================
Comment at: lld/ELF/Thunks.cpp:1043
+    return (type == R_PPC64_REL24_NOTOC)
+               ? (Thunk *)make<PPC64PCRelPLTStub>(s)
+               : (Thunk *)make<PPC64PltCallStub>(s);
----------------
sfertile wrote:
> Are the casts needed?
Yeah, the ternary conditional operator would complain since `make<PPC64PCRelPLTStub>(s)` and `make<PPC64PltCallStub>(s)` has different value type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83669/new/

https://reviews.llvm.org/D83669