[PATCH] D84276: GlobalISel: Don't fail translate on intrinsics with metadata

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 09:52:01 PDT 2020


paquette added a comment.

In rG55d10423a6a1f8286be05651b9c7143ef4e58b22 <https://reviews.llvm.org/rG55d10423a6a1f8286be05651b9c7143ef4e58b22>

> [GlobalISel] Don't translate intrinsics with metadata parameters. 
>  Some intrinsics take metadata parameters.  These all need custom handling of some form, and cannot possibly be lowered generically to G_INTRINSIC calls with vreg operands. Reject them, instead of hitting an assert later in getOrCreateVReg.

Is this still relevant? I guess we're just using custom legalization and selection to handle these nowadays?

(@ab do you have opinions here?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84276/new/

https://reviews.llvm.org/D84276





More information about the llvm-commits mailing list