[PATCH] D84486: [lld-macho] Support -filelist

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Although Im not a fan of the test, I don't think that is necessarily a blocking thing.



================
Comment at: lld/test/MachO/filelist.s:22
+# RUN: lld -flavor darwinnew -Z -filelist filelist %t/test.o -o %t/test
+# RUN: llvm-objdump --syms %t/test | FileCheck %s --check-prefix=SECOND
+
----------------
I'm not too fond of this test ... it relies on `subsections_via_symbols` not being present which is actually odd for MachO.  An alternative would be to rely on the multiple definitions check to identify the source for the second definition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84486/new/

https://reviews.llvm.org/D84486