[PATCH] D83089: DomTree: Extract (mostly) read-only logic into type-erased base classes

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 09:13:22 PDT 2020


nhaehnle updated this revision to Diff 280482.
nhaehnle added a comment.

  v6:
  - style change: iDom -> idom; it's arguable whether this is really
    invalid, since it is actually standard camelCase, but clang-tidy
    complains about it so... *shrug*
  - rename {to,from}Generic -> {wrap,unwrap}Ref


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83089/new/

https://reviews.llvm.org/D83089

Files:
  llvm/include/llvm/CodeGen/MachineDominators.h
  llvm/include/llvm/Support/GenericDomTree.h
  llvm/include/llvm/Support/GenericDomTreeConstruction.h
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/GenericDomTree.cpp
  llvm/lib/Transforms/Scalar/ADCE.cpp
  llvm/lib/Transforms/Scalar/NewGVN.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83089.280482.patch
Type: text/x-patch
Size: 43338 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200724/4e992e7e/attachment.bin>


More information about the llvm-commits mailing list