[PATCH] D83818: [AArch64] fjcvtzs,rmif,cfinv,setf* all clobber nzcv

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/fjcvtzs.mir:1
+# RUN: llc -o - %s -mtriple=arm64-eabi -mattr=+jsconv -run-pass=legalizer
+
----------------
I am very sorry, looking at this, I am changing my mind on this. This test is not testing anything, there are no CHECK tags. And in fact, what you had before is better and what we want: an llc test fed with an .ll, using stop-after to produce mir and check for implicit defs/uses.



================
Comment at: llvm/test/CodeGen/AArch64/flag-mainpulation.mir:1
+# RUN: llc -o - %s -mtriple=arm64-eabi -mattr=+jsconv -run-pass=legalizer
+
----------------
nit: typo in the file name: flag-mainpulation.mir


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83818/new/

https://reviews.llvm.org/D83818