[PATCH] D80274: [MachineVerifier] Handle the PHI node for verifyLiveVariables()

[Zhang Kang via Phabricator via llvm-commits]

ZhangKang marked 3 inline comments as done.
ZhangKang added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2304
     }
+
+    // Handle the PHI node.
----------------
bjope wrote:
> Can't you just simply loop over the PHI nodes belonging to MBB here, finding all the PHI-related <vreg, pred> pairs.
> That should give you all the additional vregs that should be live in (that earlier has been left our from the vregsLiveIn map), and from which predecessors the value should be required.
> 
> That way you do not need the PHIVarFrom map (and being even more dependant on what visitMachineInstrBefore is doing). I mean the map is only caching the information stored in the PHI instructions anyway.
Have updated the patch to remvoe `PHIVarFrom `.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80274/new/

https://reviews.llvm.org/D80274